feat: 扩展本地主题兼容能力
This commit is contained in:
@@ -7,6 +7,7 @@ import {
|
||||
import {
|
||||
extname,
|
||||
isAbsolute,
|
||||
posix,
|
||||
relative,
|
||||
resolve,
|
||||
sep
|
||||
@@ -39,6 +40,10 @@ const assetContentTypes: Record<string, string> = {
|
||||
".woff2": "font/woff2"
|
||||
};
|
||||
|
||||
const cssImportPattern =
|
||||
/@import\s+(?:url\(\s*(?:\"([^\"]+)\"|'([^']+)'|([^'\"\s)]+))\s*\)|\"([^\"]+)\"|'([^']+)')\s*;/gi;
|
||||
const maximumCssImportDepth = 8;
|
||||
|
||||
function isMissingFileError(error: unknown) {
|
||||
return (
|
||||
error instanceof Error &&
|
||||
@@ -119,6 +124,9 @@ async function readThemeRoot(
|
||||
throw new Error("主题 bundled 标记与来源不一致");
|
||||
}
|
||||
|
||||
if (manifest.base) {
|
||||
await resolveThemeFile(directory, manifest.base);
|
||||
}
|
||||
await resolveThemeFile(directory, manifest.entry);
|
||||
if (manifest.print) {
|
||||
await resolveThemeFile(directory, manifest.print);
|
||||
@@ -145,13 +153,12 @@ function encodeAssetPath(path: string) {
|
||||
.join("/");
|
||||
}
|
||||
|
||||
function prepareThemeCss(css: string, themeId: string) {
|
||||
const withoutTyporaExportIncludes = css.replace(
|
||||
/^\s*@include-when-export\s+url\([^;\r\n]+;\s*$/gim,
|
||||
""
|
||||
);
|
||||
|
||||
return withoutTyporaExportIncludes.replace(
|
||||
function prepareCssSegment(
|
||||
css: string,
|
||||
themeId: string,
|
||||
cssDirectory: string
|
||||
) {
|
||||
return css.replace(
|
||||
/url\(\s*(['"]?)([^'")]+)\1\s*\)/gi,
|
||||
(match, _quote: string, rawValue: string) => {
|
||||
const value = rawValue.trim();
|
||||
@@ -171,11 +178,96 @@ function prepareThemeCss(css: string, themeId: string) {
|
||||
throw new Error(`主题资源路径不安全:${value}`);
|
||||
}
|
||||
|
||||
return `url("/api/themes/${encodeURIComponent(themeId)}/assets/${encodeAssetPath(normalized)}")`;
|
||||
const assetPath = posix.normalize(posix.join(cssDirectory, normalized));
|
||||
if (
|
||||
assetPath === ".." ||
|
||||
assetPath.startsWith("../") ||
|
||||
assetPath.startsWith("/")
|
||||
) {
|
||||
throw new Error(`主题资源路径越界:${value}`);
|
||||
}
|
||||
|
||||
return `url("/api/themes/${encodeURIComponent(themeId)}/assets/${encodeAssetPath(assetPath)}")`;
|
||||
}
|
||||
);
|
||||
}
|
||||
|
||||
function readImportedPath(match: RegExpMatchArray) {
|
||||
return match.slice(1).find((value): value is string => value !== undefined);
|
||||
}
|
||||
|
||||
function normalizeCssPath(relativePath: string) {
|
||||
const normalized = relativePath.replaceAll("\\", "/");
|
||||
if (
|
||||
normalized.startsWith("/") ||
|
||||
normalized.split("/").includes("..") ||
|
||||
/^[a-z][a-z0-9+.-]*:/i.test(normalized)
|
||||
) {
|
||||
throw new Error(`主题 CSS 路径不安全:${relativePath}`);
|
||||
}
|
||||
|
||||
return posix.normalize(normalized.replace(/^\.\//, ""));
|
||||
}
|
||||
|
||||
async function loadThemeCssFile(
|
||||
theme: ThemeRecord,
|
||||
relativePath: string,
|
||||
importStack: string[] = []
|
||||
): Promise<string> {
|
||||
const normalizedPath = normalizeCssPath(relativePath);
|
||||
if (importStack.includes(normalizedPath)) {
|
||||
throw new Error(
|
||||
`主题 CSS 存在循环引用:${[...importStack, normalizedPath].join(" -> ")}`
|
||||
);
|
||||
}
|
||||
if (importStack.length >= maximumCssImportDepth) {
|
||||
throw new Error(`主题 CSS 导入层级超过 ${maximumCssImportDepth} 层`);
|
||||
}
|
||||
|
||||
const cssPath = await resolveThemeFile(theme.directory, normalizedPath);
|
||||
const css = (await readFile(cssPath, "utf8")).replace(
|
||||
/^\s*@include-when-export\s+url\([^;\r\n]+;\s*$/gim,
|
||||
""
|
||||
);
|
||||
const cssDirectory = posix.dirname(normalizedPath);
|
||||
const matches = [...css.matchAll(cssImportPattern)];
|
||||
let result = "";
|
||||
let previousEnd = 0;
|
||||
|
||||
for (const match of matches) {
|
||||
const matchStart = match.index ?? 0;
|
||||
result += prepareCssSegment(
|
||||
css.slice(previousEnd, matchStart),
|
||||
theme.manifest.id,
|
||||
cssDirectory
|
||||
);
|
||||
|
||||
const importedPath = readImportedPath(match);
|
||||
if (!importedPath) {
|
||||
throw new Error(`无法解析主题 CSS 导入:${match[0]}`);
|
||||
}
|
||||
const normalizedImport = normalizeCssPath(importedPath);
|
||||
const importPath = posix.normalize(posix.join(cssDirectory, normalizedImport));
|
||||
result += await loadThemeCssFile(theme, importPath, [
|
||||
...importStack,
|
||||
normalizedPath
|
||||
]);
|
||||
previousEnd = matchStart + match[0].length;
|
||||
}
|
||||
|
||||
const remainder = css.slice(previousEnd);
|
||||
result += prepareCssSegment(
|
||||
remainder,
|
||||
theme.manifest.id,
|
||||
cssDirectory
|
||||
);
|
||||
if (/@import\b/i.test(result)) {
|
||||
throw new Error("主题包含不支持的 CSS @import 语法");
|
||||
}
|
||||
|
||||
return result;
|
||||
}
|
||||
|
||||
export function createThemeRegistry(options: ThemeRegistryOptions) {
|
||||
async function list() {
|
||||
const [bundledThemes, localThemes] = await Promise.all([
|
||||
@@ -206,16 +298,17 @@ export function createThemeRegistry(options: ThemeRegistryOptions) {
|
||||
}
|
||||
|
||||
const cssFiles = [
|
||||
await resolveThemeFile(theme.directory, theme.manifest.entry),
|
||||
...(theme.manifest.base ? [theme.manifest.base] : []),
|
||||
theme.manifest.entry,
|
||||
...(theme.manifest.print
|
||||
? [await resolveThemeFile(theme.directory, theme.manifest.print)]
|
||||
? [theme.manifest.print]
|
||||
: [])
|
||||
];
|
||||
const css = (
|
||||
await Promise.all(cssFiles.map((path) => readFile(path, "utf8")))
|
||||
return (
|
||||
await Promise.all(
|
||||
cssFiles.map((path) => loadThemeCssFile(theme, path))
|
||||
)
|
||||
).join("\n");
|
||||
|
||||
return prepareThemeCss(css, themeId);
|
||||
}
|
||||
|
||||
async function getAsset(themeId: string, assetPath: string) {
|
||||
|
||||
+106
-19
@@ -4,10 +4,32 @@ import { mkdtemp, mkdir, rm, writeFile } from "node:fs/promises";
|
||||
import { tmpdir } from "node:os";
|
||||
import { join } from "node:path";
|
||||
import { buildApp } from "../src/app.js";
|
||||
import { createThemeRegistry } from "../src/theme-registry.js";
|
||||
|
||||
let app: FastifyInstance | undefined;
|
||||
let temporaryDirectory: string | undefined;
|
||||
|
||||
function localThemeManifest(
|
||||
id: string,
|
||||
overrides: Record<string, unknown> = {}
|
||||
) {
|
||||
return {
|
||||
manifestVersion: 1,
|
||||
id,
|
||||
name: "本地测试主题",
|
||||
version: "local",
|
||||
description: "本地主题测试",
|
||||
author: "test",
|
||||
license: "local-only",
|
||||
entry: "theme.css",
|
||||
domPreset: "typora",
|
||||
defaultFontSize: "16px",
|
||||
supportedFeatures: ["code", "table"],
|
||||
bundled: false,
|
||||
...overrides
|
||||
};
|
||||
}
|
||||
|
||||
afterEach(async () => {
|
||||
await app?.close();
|
||||
if (temporaryDirectory) {
|
||||
@@ -64,36 +86,42 @@ describe("预览 API", () => {
|
||||
it("发现本地主题并安全提供相对字体资源", async () => {
|
||||
temporaryDirectory = await mkdtemp(join(tmpdir(), "md-to-pdf-theme-"));
|
||||
const themeDirectory = join(temporaryDirectory, "local-test");
|
||||
await mkdir(join(themeDirectory, "fonts"), { recursive: true });
|
||||
await mkdir(join(themeDirectory, "partials", "fonts"), {
|
||||
recursive: true
|
||||
});
|
||||
await writeFile(
|
||||
join(themeDirectory, "theme.json"),
|
||||
JSON.stringify({
|
||||
manifestVersion: 1,
|
||||
id: "local-test",
|
||||
name: "本地测试主题",
|
||||
version: "local",
|
||||
description: "本地主题测试",
|
||||
author: "test",
|
||||
license: "local-only",
|
||||
entry: "theme.css",
|
||||
domPreset: "typora",
|
||||
defaultFontSize: "16px",
|
||||
supportedFeatures: ["code", "table"],
|
||||
bundled: false
|
||||
}),
|
||||
JSON.stringify(
|
||||
localThemeManifest("local-test", {
|
||||
base: "typora-base.css"
|
||||
})
|
||||
),
|
||||
"utf8"
|
||||
);
|
||||
await writeFile(
|
||||
join(themeDirectory, "typora-base.css"),
|
||||
"/* base-layer */ table { width: 100%; border-collapse: collapse; }",
|
||||
"utf8"
|
||||
);
|
||||
await writeFile(
|
||||
join(themeDirectory, "theme.css"),
|
||||
[
|
||||
"@include-when-export url(https://example.com/font.css);",
|
||||
"@font-face { src: url('./fonts/test.woff2') format('woff2'); }",
|
||||
"@import \"partials/typography.css\";",
|
||||
"#write { font-family: LocalTest; }"
|
||||
].join("\n"),
|
||||
"utf8"
|
||||
);
|
||||
await writeFile(
|
||||
join(themeDirectory, "fonts", "test.woff2"),
|
||||
join(themeDirectory, "partials", "typography.css"),
|
||||
[
|
||||
"/* imported-layer */",
|
||||
"@font-face { src: url('./fonts/test.woff2') format('woff2'); }"
|
||||
].join("\n"),
|
||||
"utf8"
|
||||
);
|
||||
await writeFile(
|
||||
join(themeDirectory, "partials", "fonts", "test.woff2"),
|
||||
Buffer.from([0, 1, 2, 3])
|
||||
);
|
||||
|
||||
@@ -123,15 +151,74 @@ describe("预览 API", () => {
|
||||
expect(cssResponse.statusCode).toBe(200);
|
||||
expect(cssResponse.body).not.toContain("@include-when-export");
|
||||
expect(cssResponse.body).toContain(
|
||||
"/api/themes/local-test/assets/fonts/test.woff2"
|
||||
"/api/themes/local-test/assets/partials/fonts/test.woff2"
|
||||
);
|
||||
expect(cssResponse.body.indexOf("base-layer")).toBeLessThan(
|
||||
cssResponse.body.indexOf("imported-layer")
|
||||
);
|
||||
expect(cssResponse.body.indexOf("imported-layer")).toBeLessThan(
|
||||
cssResponse.body.indexOf("font-family: LocalTest")
|
||||
);
|
||||
|
||||
const assetResponse = await app.inject({
|
||||
method: "GET",
|
||||
url: "/api/themes/local-test/assets/fonts/test.woff2"
|
||||
url: "/api/themes/local-test/assets/partials/fonts/test.woff2"
|
||||
});
|
||||
expect(assetResponse.statusCode).toBe(200);
|
||||
expect(assetResponse.headers["content-type"]).toContain("font/woff2");
|
||||
expect(assetResponse.rawPayload).toEqual(Buffer.from([0, 1, 2, 3]));
|
||||
});
|
||||
|
||||
it("拒绝主题 CSS 循环导入", async () => {
|
||||
temporaryDirectory = await mkdtemp(join(tmpdir(), "md-to-pdf-theme-"));
|
||||
const bundledRoot = join(temporaryDirectory, "bundled");
|
||||
const localRoot = join(temporaryDirectory, "local");
|
||||
const themeDirectory = join(localRoot, "cycle-test");
|
||||
await mkdir(bundledRoot, { recursive: true });
|
||||
await mkdir(themeDirectory, { recursive: true });
|
||||
await writeFile(
|
||||
join(themeDirectory, "theme.json"),
|
||||
JSON.stringify(localThemeManifest("cycle-test")),
|
||||
"utf8"
|
||||
);
|
||||
await writeFile(
|
||||
join(themeDirectory, "theme.css"),
|
||||
'@import "nested.css";',
|
||||
"utf8"
|
||||
);
|
||||
await writeFile(
|
||||
join(themeDirectory, "nested.css"),
|
||||
'@import "theme.css";',
|
||||
"utf8"
|
||||
);
|
||||
|
||||
const registry = createThemeRegistry({ bundledRoot, localRoot });
|
||||
await expect(registry.getCss("cycle-test")).rejects.toThrow(
|
||||
"主题 CSS 存在循环引用"
|
||||
);
|
||||
});
|
||||
|
||||
it("拒绝主题 CSS 导入外部地址", async () => {
|
||||
temporaryDirectory = await mkdtemp(join(tmpdir(), "md-to-pdf-theme-"));
|
||||
const bundledRoot = join(temporaryDirectory, "bundled");
|
||||
const localRoot = join(temporaryDirectory, "local");
|
||||
const themeDirectory = join(localRoot, "external-test");
|
||||
await mkdir(bundledRoot, { recursive: true });
|
||||
await mkdir(themeDirectory, { recursive: true });
|
||||
await writeFile(
|
||||
join(themeDirectory, "theme.json"),
|
||||
JSON.stringify(localThemeManifest("external-test")),
|
||||
"utf8"
|
||||
);
|
||||
await writeFile(
|
||||
join(themeDirectory, "theme.css"),
|
||||
'@import "https://example.com/theme.css";',
|
||||
"utf8"
|
||||
);
|
||||
|
||||
const registry = createThemeRegistry({ bundledRoot, localRoot });
|
||||
await expect(registry.getCss("external-test")).rejects.toThrow(
|
||||
"主题 CSS 路径不安全"
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user